Updates in response to source-build-internal team renamed to source-build #15148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSimons
requested review from
mmitche,
a team,
ellahathaway and
mthalman
MichaelSimons
commented
Oct 8, 2024
| @@ -6,31 +6,30 @@ This document provides guidelines on the types of source code that are permissib | |||
|
|
|||
| ## Binaries | |||
|
|
|||
| ### Policy | |||
| ### Binary Policy | |||
There was a problem hiding this comment.
There were a number of markdown linter violations in this file I decided to address since touching.
MichaelSimons
commented
Oct 8, 2024
eng/DotNetBuild.props
Outdated
There was a problem hiding this comment.
The file rename is not strictly required but I thought it was a good opportunity to cleanup.
ellahathaway
previously approved these changes
Oct 8, 2024
mthalman
previously approved these changes
Oct 8, 2024
|
@MichaelSimons I see a couple of remaining refs in |
MichaelSimons
dismissed stale reviews from mthalman and ellahathaway
via
b959a50
Fixed in b959a50. |
mmitche
approved these changes
Oct 9, 2024
ellahathaway
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to dotnet/source-build#4645.
The proposed header changes made to
eng/DotNetBuild.propsandeng/SourceBuildPrebuiltBaseline.xmlare what I plan to update all product repo's to.